fix(ci): combine crashlog EXCEPTION_POINTERS fix and dead-code allow attributes #6

Closed

HexC0d3rz wants to merge 4 commits from fix/ci-combine-crashlog-and-deadcode into main

HexC0d3rz commented

2026-06-16 16:27:06 -04:00

(Migrated from github.com)

Summary

Consolidates the two previously-separate CI fixes (#4 and #5) into a single branch so all CI checks can pass together.

Background

PR #4 (fix/ci-crashlog-exception-type): fixes E0308 and E0610 in crates/zeno-agent/src/crashlog.rs — the Windows top-level exception filter expected *const EXCEPTION_POINTERS (not *mut) and ExceptionCode is an i32 type alias (not a tuple struct).
PR #5 (fix/ci-dead-code-payload-state): silences -D warnings dead-code lints in crates/zeno-installer/src/payload.rs and crates/zeno-server/src/state.rs by adding #[allow(dead_code)] attributes with explanatory comments.

Neither fix alone is sufficient: PR #4 is blocked by the dead-code warnings that PR #5 silences, and PR #5 is blocked by the crashlog compile errors that PR #4 fixes. The two PRs also fail independently because each is built on main and only contains one of the two required fixes.

This PR

Merges both branches into fix/ci-combine-crashlog-and-deadcode with no conflicts (the two source sets are disjoint: crashlog.rs vs. payload.rs + state.rs).
After this lands, both #4 and #5 should be closed as superseded.

Verification

Local: cargo fmt --all -- --check clean; cargo check --workspace --lib clean.
All three target files are present in the merge: crates/zeno-agent/src/crashlog.rs, crates/zeno-installer/src/payload.rs, crates/zeno-server/src/state.rs.

Supersedes #4 and #5.

## Summary Consolidates the two previously-separate CI fixes (#4 and #5) into a single branch so all CI checks can pass together. ## Background - **PR #4** (`fix/ci-crashlog-exception-type`): fixes `E0308` and `E0610` in `crates/zeno-agent/src/crashlog.rs` — the Windows top-level exception filter expected `*const EXCEPTION_POINTERS` (not `*mut`) and `ExceptionCode` is an `i32` type alias (not a tuple struct). - **PR #5** (`fix/ci-dead-code-payload-state`): silences `-D warnings` dead-code lints in `crates/zeno-installer/src/payload.rs` and `crates/zeno-server/src/state.rs` by adding `#[allow(dead_code)]` attributes with explanatory comments. Neither fix alone is sufficient: PR #4 is blocked by the dead-code warnings that PR #5 silences, and PR #5 is blocked by the crashlog compile errors that PR #4 fixes. The two PRs also fail independently because each is built on `main` and only contains one of the two required fixes. ## This PR - Merges both branches into `fix/ci-combine-crashlog-and-deadcode` with no conflicts (the two source sets are disjoint: `crashlog.rs` vs. `payload.rs` + `state.rs`). - After this lands, both #4 and #5 should be closed as superseded. ## Verification - Local: `cargo fmt --all -- --check` clean; `cargo check --workspace --lib` clean. - All three target files are present in the merge: `crates/zeno-agent/src/crashlog.rs`, `crates/zeno-installer/src/payload.rs`, `crates/zeno-server/src/state.rs`. Supersedes #4 and #5.

HexC0d3rz commented

2026-06-17 10:56:18 -04:00

(Migrated from github.com)

Closing as superseded by PR #7 (), which is now green and contains the same EXCEPTION_POINTERS / dead-code fixes plus additional cleanups in and the E0308/E0610 follow-up. Both branches of work have been merged into #7; merging #7 to main will land the combined result.